[
https://issues.apache.org/jira/browse/DRILL-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179073#comment-17179073
]
ASF GitHub Bot commented on DRILL-7745:
---------------------------------------
cgivre commented on pull request #2084:
URL: https://github.com/apache/drill/pull/2084#issuecomment-674957594
@dbw9580
This is looking pretty good. I'm going to do a final check this evening or
tomorrow, but can you please:
1. Squash all commits and add message of `DRILL-7745: Add storage plugin
for IPFS` as the commit message
2. Go through and do a final code hygiene check (make sure there are no
extra spaces, commented out blocks etc). Drill does have a code formatter[1]
and just verify that the code complies with the coding standards for spacing
and all that. (I didn't see anything jump out at me, but it always helps to
double check)
Thanks!
[1]: https://drill.apache.org/docs/apache-drill-contribution-guidelines/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add storage plugin for IPFS
> ---------------------------
>
> Key: DRILL-7745
> URL: https://issues.apache.org/jira/browse/DRILL-7745
> Project: Apache Drill
> Issue Type: New Feature
> Components: Storage - Other
> Affects Versions: 1.18.0
> Reporter: Bowen Ding
> Assignee: Bowen Ding
> Priority: Major
>
> See introduction here: [https://github.com/bdchain/Minerva]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
