[ 
https://issues.apache.org/jira/browse/DRILL-7795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214237#comment-17214237
 ] 

ASF GitHub Bot commented on DRILL-7795:
---------------------------------------

sanel commented on a change in pull request #2107:
URL: https://github.com/apache/drill/pull/2107#discussion_r504936707



##########
File path: contrib/native/client/src/clientlib/errmsgs.hpp
##########
@@ -59,7 +59,8 @@ namespace Drill{
 #define ERR_CONN_SSL_CN         DRILL_ERR_START+27
 #define ERR_CONN_SSL_CERTVERIFY DRILL_ERR_START+28
 #define ERR_CONN_SSL_PROTOVER   DRILL_ERR_START+29
-#define ERR_CONN_MAX            DRILL_ERR_START+29
+#define ERR_CONN_SSL_SNI        DRILL_ERR_START+30
+#define ERR_CONN_MAX            DRILL_ERR_START+30

Review comment:
       In that case I'd just add comment for the last entry. Easy to overlook.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Add option to native Drill Client to set TLS SNI property
> ---------------------------------------------------------
>
>                 Key: DRILL-7795
>                 URL: https://issues.apache.org/jira/browse/DRILL-7795
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Client - C++
>            Reporter: James Duong
>            Priority: Major
>
> Add an option to the C++ DrillClient library that sets the TLS SNI extension 
> to let you set the Server Name Indication TLS property. If no option for this 
> value is specified, choose a default based on the target host.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to