[
https://issues.apache.org/jira/browse/DRILL-7847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269388#comment-17269388
]
ASF GitHub Bot commented on DRILL-7847:
---------------------------------------
luocooong commented on a change in pull request #2147:
URL: https://github.com/apache/drill/pull/2147#discussion_r561966837
##########
File path: contrib/storage-mongo/pom.xml
##########
@@ -28,7 +28,7 @@
<artifactId>drill-mongo-storage</artifactId>
- <name>contrib/mongo-storage-plugin</name>
+ <name>Drill : Contrib : Storage : Mongo</name>
Review comment:
I recommend that `Mongo` to `MongoDB`
##########
File path: drill-yarn/pom.xml
##########
@@ -28,7 +28,7 @@
<artifactId>drill-yarn</artifactId>
<packaging>jar</packaging>
- <name>Drill-on-YARN</name>
+ <name>Drill : Hadoop YARN</name>
Review comment:
I recommend that `Hadoop YARN` to `On-YARN`
##########
File path: contrib/format-httpd/pom.xml
##########
@@ -26,7 +26,7 @@
<version>1.19.0-SNAPSHOT</version>
</parent>
<artifactId>drill-format-httpd</artifactId>
- <name>contrib/httpd-format-plugin</name>
+ <name>Drill : Contrib : Format : Httpd/Nginx access log</name>
Review comment:
I recommend that `Nginx access log` to `Nginx Access Log`
##########
File path: metastore/rdbms-metastore/pom.xml
##########
@@ -28,7 +28,7 @@
</parent>
<artifactId>drill-rdbms-metastore</artifactId>
- <name>metastore/Drill RDBMS Metastore</name>
+ <name>Drill : Metastore : RDBMS Metastore</name>
Review comment:
I recommend that `RDBMS Metastore` to `RDBMS`
##########
File path: contrib/storage-hive/hive-exec-shade/pom.xml
##########
@@ -29,7 +29,7 @@
<artifactId>drill-hive-exec-shaded</artifactId>
<packaging>jar</packaging>
- <name>contrib/hive-storage-plugin/hive-exec-shaded</name>
+ <name>Drill : Contrib : Storage : Hive : Exec shaded</name>
Review comment:
I recommend that `Exec shaded` to `Exec Shaded`
##########
File path: logical/pom.xml
##########
@@ -29,7 +29,7 @@
<artifactId>drill-logical</artifactId>
<packaging>jar</packaging>
- <name>Logical Plan, Base expressions</name>
+ <name>Drill : Logical Plan, Base expressions</name>
Review comment:
I recommend that `Drill : Logical Plan`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Naming the maven modules
> ------------------------
>
> Key: DRILL-7847
> URL: https://issues.apache.org/jira/browse/DRILL-7847
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Reporter: Niels Basjes
> Assignee: Niels Basjes
> Priority: Trivial
>
> When building Drill the maven output shows the various modules with names
> that are inconsistent and hard to read.
> I propose to have a consistent naming of all modules that is easier for the
> developer to read and understand.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
