[
https://issues.apache.org/jira/browse/DRILL-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292266#comment-17292266
]
ASF GitHub Bot commented on DRILL-7821:
---------------------------------------
luocooong commented on a change in pull request #2169:
URL: https://github.com/apache/drill/pull/2169#discussion_r584215188
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java
##########
@@ -804,4 +804,59 @@ public void testConvertFromJson() throws Exception {
.baselineValues("2", "abc")
.go();
}
+ @Test // DRILL-7821
Review comment:
@mkusnir Minor thing... Missing the new line between the `}` and
`@Test`.
You can push a revision again (please squash commits), then ready to merge,
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Treat Empty String as NULL in JSON Reader
> -----------------------------------------
>
> Key: DRILL-7821
> URL: https://issues.apache.org/jira/browse/DRILL-7821
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JSON
> Affects Versions: 1.17.0
> Reporter: Charles Givre
> Priority: Major
> Fix For: 1.19.0
>
> Attachments: servicenow.json
>
>
> In the JSON below the field `resolved_by` first appears as a map but in
> records when it is not defined, is empty strings. This causes
> SchemaChangeExceptions.
> I'm wondering if Drill could either ignore or interpret the empty strings as
> null so that the query will complete.
>
> {{{
> ....
> "skills": "",
> "number": "INC0000001",
> *"resolved_by": {*
> *"link":
> "https://empmgill4.service-now.com/api/now/table/sys_user/6816f79cc0a8016401c5a33be04be441",*
> *"value": "6816f79cc0a8016401c5a33be04be441"*
> *},*
> "sys_updated_by": "admin"
> ...
> },
> { ... "number": "INC0000002", *"resolved_by": "",*
> "sys_updated_by": "admin", ... }}
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
