[ 
https://issues.apache.org/jira/browse/DRILL-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379058#comment-17379058
 ] 

ASF GitHub Bot commented on DRILL-7926:
---------------------------------------

dzamo commented on pull request #2268:
URL: https://github.com/apache/drill/pull/2268#issuecomment-878090634


   @oleg-zinovev thanks for adapting your solution to java.time.  I agree that 
the API it offers for this problem looks like a downgrade but there is already 
an initiative in Drill to migrate from Joda to java.time, as Joda warns us that 
we should.  There are some other issues I can see.  There is a @Workspace 
variable being used but 1) it's not a Holder type and 2) this is a simple 
function not an aggregate function.  I'm going to pull your PR branch down to 
my machine to look more closely at this so we can get this important fix merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> The " age " function is not working properly.
> ---------------------------------------------
>
>                 Key: DRILL-7926
>                 URL: https://issues.apache.org/jira/browse/DRILL-7926
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Functions - Drill
>    Affects Versions: 1.17.0, 1.18.0
>            Reporter: Александр Глухов
>            Priority: Blocker
>         Attachments: image-2021-05-13-16-17-21-154.png, screenshot-1.png, 
> screenshot-2.png
>
>
> The " age " function is not working properly.
>  *Playback steps*
> {code:sql}
> select extract(year from m. "years") `years`  from (select age('2021-05-13', 
> '2007-07-02') `years") m{code}
> *Expected result* 13.
> *Actual result* 14.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to