[
https://issues.apache.org/jira/browse/DRILL-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409525#comment-17409525
]
ASF GitHub Bot commented on DRILL-7984:
---------------------------------------
vvysotskyi commented on a change in pull request #2290:
URL: https://github.com/apache/drill/pull/2290#discussion_r701925438
##########
File path:
logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java
##########
@@ -19,11 +19,9 @@
import com.fasterxml.jackson.annotation.JsonIgnore;
-import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")
-@JsonInclude(JsonInclude.Include.NON_DEFAULT)
Review comment:
Please revert these changes. It helps to preserve backward compatibility
for the case when the new option was added, the user started a newer version of
Drill, but after that decided to use previous one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Support Clickhouse using JDBC Storage Plugin
> --------------------------------------------
>
> Key: DRILL-7984
> URL: https://issues.apache.org/jira/browse/DRILL-7984
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - JDBC
> Reporter: wtf
> Assignee: wtf
> Priority: Major
>
> Trino(Formerly PrestoSQL, branched from Presto) has already supportted
> [Clickhouse|[https://trino.io/docs/current/connector/clickhouse.html]|https://trino.io/docs/current/connector/clickhouse.html],]
> using
> [clickhouse-jdbc|[https://github.com/ClickHouse/clickhouse-jdbc]|https://github.com/ClickHouse/clickhouse-jdbc]
> When connecting to clickhouse using drill jdbc plugin, found one uncompatible
> place:
> clickhouse-jdbc return constant string "default" when call getCatalogs, and
> return all databases when call getSchemas(input catalog is not used). All
> schemas will be appended after the "default" catalog, which will cause the
> query to fail.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
