[
https://issues.apache.org/jira/browse/DRILL-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430562#comment-17430562
]
ASF GitHub Bot commented on DRILL-8011:
---------------------------------------
cgivre commented on a change in pull request #2337:
URL: https://github.com/apache/drill/pull/2337#discussion_r731899843
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/DropboxFileSystem.java
##########
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.drill.exec.store.dfs;
+
+import com.dropbox.core.DbxException;
+import com.dropbox.core.DbxRequestConfig;
+import com.dropbox.core.v2.DbxClientV2;
+import com.dropbox.core.v2.files.FileMetadata;
+import com.dropbox.core.v2.files.FolderMetadata;
+import com.dropbox.core.v2.files.ListFolderResult;
+import com.dropbox.core.v2.files.Metadata;
+import org.apache.hadoop.fs.FSDataInputStream;
+import org.apache.hadoop.fs.FSDataOutputStream;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.PositionedReadable;
+import org.apache.hadoop.fs.Seekable;
+import org.apache.hadoop.fs.permission.FsPermission;
+import org.apache.hadoop.util.Progressable;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+public class DropboxFileSystem extends FileSystem {
+ private static final Logger logger =
LoggerFactory.getLogger(DropboxFileSystem.class);
+
+ private static final String ERROR_MSG = "Dropbox is read only.";
+ private Path workingDirectory;
+ private DbxClientV2 client;
+ private FileStatus[] fileStatuses;
+ private final Map<String,FileStatus> fileStatusCache = new HashMap<>();
+
+ @Override
+ public URI getUri() {
+ try {
+ return new URI("dropbox:///");
+ } catch (URISyntaxException e) {
+ throw new RuntimeException(e);
+ }
+ }
+
+ @Override
+ public FSDataInputStream open(Path path, int bufferSize) throws IOException {
+ FSDataInputStream fsDataInputStream;
+ String filename = getFileName(path);
+ client = getClient();
+ ByteArrayOutputStream out = new ByteArrayOutputStream();
+ try {
+ client.files().download(filename).download(out);
+ fsDataInputStream = new FSDataInputStream(new
SeekableByteArrayInputStream(out.toByteArray()));
+ } catch (DbxException e) {
+ throw new IOException(e.getMessage());
+ }
+ return fsDataInputStream;
+ }
+
+ @Override
+ public FSDataOutputStream create(Path f,
+ FsPermission permission,
+ boolean overwrite,
+ int bufferSize,
+ short replication,
+ long blockSize,
+ Progressable progress) throws IOException {
+ throw new IOException(ERROR_MSG);
+ }
+
+ @Override
+ public FSDataOutputStream append(Path f, int bufferSize, Progressable
progress) throws IOException {
+ throw new IOException(ERROR_MSG);
+ }
+
+ @Override
+ public boolean rename(Path src, Path dst) throws IOException {
+ return false;
+ }
+
+ @Override
+ public boolean delete(Path f, boolean recursive) throws IOException {
+ throw new IOException(ERROR_MSG);
+ }
+
+ @Override
+ public FileStatus[] listStatus(Path path) throws IOException {
+ client = getClient();
+ List<FileStatus> fileStatusList = new ArrayList<>();
+
+ // Get files and folder metadata from Dropbox root directory
+ try {
+ ListFolderResult result = client.files().listFolder("");
+ while (true) {
+ for (Metadata metadata : result.getEntries()) {
+ fileStatusList.add(getFileInformation(metadata));
+ }
+ if (!result.getHasMore()) {
+ break;
+ }
+ result = client.files().listFolderContinue(result.getCursor());
+ }
+ } catch (DbxException e) {
+ throw new IOException(e.getMessage());
+ }
+
+ // Convert to Array
+ fileStatuses = new FileStatus[fileStatusList.size()];
+ for (int i = 0; i < fileStatusList.size(); i++) {
+ fileStatuses[i] = fileStatusList.get(i);
+ }
+
+ return fileStatuses;
+ }
+
+ @Override
+ public void setWorkingDirectory(Path new_dir) {
+ logger.debug("Setting working directory to: " + new_dir.getName());
+ workingDirectory = new_dir;
+ }
+
+ @Override
+ public Path getWorkingDirectory() {
+ return workingDirectory;
+ }
+
+ @Override
+ public boolean mkdirs(Path f, FsPermission permission) throws IOException {
+ throw new IOException(ERROR_MSG);
+ }
+
+ @Override
+ public FileStatus getFileStatus(Path path) throws IOException {
+ String filePath = Path.getPathWithoutSchemeAndAuthority(path).toString();
+ /*
+ * Dropbox does not allow metadata calls on the root directory
+ */
+ if (filePath.equalsIgnoreCase("/")) {
+ return new FileStatus(0, true, 1, 0, 0, new Path("/"));
+ }
+ client = getClient();
+ try {
+ Metadata metadata = client.files().getMetadata(filePath);
+ return getFileInformation(metadata);
+ } catch (Exception e) {
+ throw new IOException("Error accessing file " + filePath + "\n" +
e.getMessage());
+ }
+ }
+
+ private FileStatus getFileInformation(Metadata metadata) {
+ if (fileStatusCache.containsKey(metadata.getPathLower())){
Review comment:
That is correct. Drill seems to make a lot of calls to the filesystem
to gather metadata. Since Dropbox is a network protocol, it was seriously
slowing things down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Dropbox File System to Drill
> --------------------------------
>
> Key: DRILL-8011
> URL: https://issues.apache.org/jira/browse/DRILL-8011
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
> Affects Versions: 1.19.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.20.0
>
>
> This PR proposes to add the ability to query files stored in Dropbox to
> Apache Drill.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
