[
https://issues.apache.org/jira/browse/DRILL-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454778#comment-17454778
]
ASF GitHub Bot commented on DRILL-8069:
---------------------------------------
pjfanning commented on pull request #2396:
URL: https://github.com/apache/drill/pull/2396#issuecomment-988141665
@cgivre it passed for me locally and also now in the automated build - I
plan to make another edit though, I just want to upgrade excel-streaming-reader
version because of a bug that was found
(https://github.com/pjfanning/excel-streaming-reader/issues/80 - I have a
release that disables this new feature by default, a feature that drill doesn't
need)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> remove use of excel sheet getLastRowNum
> ---------------------------------------
>
> Key: DRILL-8069
> URL: https://issues.apache.org/jira/browse/DRILL-8069
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Data Types
> Reporter: PJ Fanning
> Priority: Major
>
> excel-streaming-reader can only get last row num from sheets that have
> dimension data and not all sheets have this set - it is safer to iterate
> through the row data and not try to shortcut the reading of the sheet based
> on getLastRowNum
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
