[
https://issues.apache.org/jira/browse/DRILL-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457847#comment-17457847
]
ASF GitHub Bot commented on DRILL-8055:
---------------------------------------
Z0ltrix commented on a change in pull request #2387:
URL: https://github.com/apache/drill/pull/2387#discussion_r767203793
##########
File path: contrib/storage-druid/README.md
##########
@@ -4,13 +4,13 @@ Drill druid storage plugin allows you to perform SQL queries
against Druid datas
This storage plugin is part of [Apache Drill](https://github.com/apache/drill)
### Tested with Druid version
-[0.16.0-incubating](https://github.com/apache/incubator-druid/releases/tag/druid-0.16.0-incubating)
+[0.22.0](https://github.com/apache/druid/releases/tag/druid-0.22.0)
Review comment:
Druid 0.17.x to 0.19.x does not have the "offset" parametser in the scan
query api, so paging is not possible. I thought it would be better to avoid all
Druid Versions < 0.20.x for scan api instead of sacrifice pagination and
reading all rows at once.
This means:
- Drill < 1.20 works well with Druid <= 0.16 (select api)
- Drill >= 1.20 will work with Druid >= 0.20 (scan api)
- Druid 0.17 to 0.19 will not be supported by Drill because of missing
offset parameter in scan api
I mentioned this in the docs
https://github.com/apache/drill-site/pull/18/files#diff-c47da4191a5cd392dabb624042159b63be990b216242e3da3491896378025e24R45
##########
File path:
contrib/storage-druid/src/test/java/org/apache/drill/exec/store/druid/rest/DruidQueryClientTest.java
##########
@@ -90,23 +90,23 @@ public void
executeQueryCalledNoResponsesFoundReturnsEmptyEventList()
new ByteArrayInputStream("[]".getBytes(StandardCharsets.UTF_8.name()));
when(httpEntity.getContent()).thenReturn(inputStream);
- DruidSelectResponse response = druidQueryClient.executeQuery(QUERY);
+ DruidScanResponse response = druidQueryClient.executeQuery(QUERY);
assertThat(response.getEvents()).isEmpty();
- assertThat(response.getPagingIdentifiers()).isEmpty();
+ //assertThat(response.getPagingIdentifiers()).isEmpty();
Review comment:
oh... yes deffinetly... missed that during coding
##########
File path:
contrib/storage-druid/src/test/java/org/apache/drill/exec/store/druid/rest/DruidQueryClientTest.java
##########
@@ -90,23 +90,23 @@ public void
executeQueryCalledNoResponsesFoundReturnsEmptyEventList()
new ByteArrayInputStream("[]".getBytes(StandardCharsets.UTF_8.name()));
when(httpEntity.getContent()).thenReturn(inputStream);
- DruidSelectResponse response = druidQueryClient.executeQuery(QUERY);
+ DruidScanResponse response = druidQueryClient.executeQuery(QUERY);
assertThat(response.getEvents()).isEmpty();
- assertThat(response.getPagingIdentifiers()).isEmpty();
+ //assertThat(response.getPagingIdentifiers()).isEmpty();
Review comment:
oh... yes definitely... missed that during coding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Druid Plugin support for V0.20 and up
> -------------------------------------
>
> Key: DRILL-8055
> URL: https://issues.apache.org/jira/browse/DRILL-8055
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - Other
> Affects Versions: 1.19.0
> Reporter: Christian Pfarr
> Priority: Major
>
> The current {{Drill Apache Druid Plugin}} (drill/contrib/storage-druid) is
> not compatible with versions later than V0.16.
> Later versions of druid have deprecated the {{SELECT}} API in favor of the
> {{SCAN}} API.
> Rework the plugin to issue {{SCAN}} calls instead of {{SELECT}} calls so that
> is can be used with later versions of Druid.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
