[
https://issues.apache.org/jira/browse/DRILL-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516603#comment-17516603
]
ASF GitHub Bot commented on DRILL-8174:
---------------------------------------
paul-rogers commented on code in PR #2511:
URL: https://github.com/apache/drill/pull/2511#discussion_r841304669
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroBatchReader.java:
##########
@@ -38,59 +45,52 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import java.io.IOException;
-import java.security.PrivilegedExceptionAction;
-
-public class AvroBatchReader implements
ManagedReader<FileScanFramework.FileSchemaNegotiator> {
+public class AvroBatchReader implements ManagedReader {
private static final Logger logger =
LoggerFactory.getLogger(AvroBatchReader.class);
- private Path filePath;
- private long endPosition;
+ private final Path filePath;
+ private final long endPosition;
private DataFileReader<GenericRecord> reader;
Review Comment:
Can `reader` be final as well?
> Convert Avro format to EVF2
> ---------------------------
>
> Key: DRILL-8174
> URL: https://issues.apache.org/jira/browse/DRILL-8174
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Cong Luo
> Assignee: Cong Luo
> Priority: Major
>
> Second refactor of the Avro format.
> We may need to resolve multiple bugs related to the Map Vector in this pull
> request.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
