[
https://issues.apache.org/jira/browse/DRILL-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539667#comment-17539667
]
ASF GitHub Bot commented on DRILL-8229:
---------------------------------------
cgivre commented on code in PR #2553:
URL: https://github.com/apache/drill/pull/2553#discussion_r877300626
##########
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##########
@@ -65,6 +65,9 @@ public void setup() {
.allTextMode(options.getOption(org.apache.drill.exec.ExecConstants.JSON_ALL_TEXT_MODE).bool_val)
.enableNanInf(options.getOption(org.apache.drill.exec.ExecConstants.JSON_READER_NAN_INF_NUMBERS).bool_val)
.build();
+
+ jsonReader.setIgnoreJSONParseErrors(
+
options.getOption(org.apache.drill.exec.ExecConstants.JSON_READER_SKIP_INVALID_RECORDS_FLAG).bool_val);
Review Comment:
Fixed! Thanks!
##########
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##########
@@ -151,6 +154,9 @@ public void setup() {
.enableNanInf(options.getOption(org.apache.drill.exec.ExecConstants.JSON_READER_NAN_INF_NUMBERS).bool_val)
.build();
+ jsonReader.setIgnoreJSONParseErrors(
+
options.getOption(org.apache.drill.exec.ExecConstants.JSON_READER_SKIP_INVALID_RECORDS_FLAG).bool_val);
Review Comment:
Fixed here as well.
> Add Parameter to Skip Malformed Records to HTTP UDF
> ----------------------------------------------------
>
> Key: DRILL-8229
> URL: https://issues.apache.org/jira/browse/DRILL-8229
> Project: Apache Drill
> Issue Type: Improvement
> Components: Functions - Drill
> Affects Versions: 1.20.1
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Minor
> Fix For: 1.20.2
>
>
> The http_get and http_request UDFs were not using the JSON parameter to skip
> malformed records. This PR fixes that.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
