[
https://issues.apache.org/jira/browse/DRILL-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540989#comment-17540989
]
ASF GitHub Bot commented on DRILL-8232:
---------------------------------------
cgivre commented on code in PR #2558:
URL: https://github.com/apache/drill/pull/2558#discussion_r879554968
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/security/vault/VaultCredentialsProvider.java:
##########
@@ -37,9 +40,11 @@
*/
public class VaultCredentialsProvider implements CredentialsProvider {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(VaultCredentialsProvider.class);
Review Comment:
Nit: There seems to be a Drill convention to call the logger `logger` in
all lower case.
> Add support for user credentials to VaultCredentialsProvider
> ------------------------------------------------------------
>
> Key: DRILL-8232
> URL: https://issues.apache.org/jira/browse/DRILL-8232
> Project: Apache Drill
> Issue Type: Improvement
> Components: Security
> Reporter: James Turton
> Assignee: James Turton
> Priority: Minor
> Fix For: 2.0.0
>
>
> The VaultCredentialsProvider can join the PlainCredentialsProvider in
> supporting user credentials, credentials that stored for each each Drill
> query user, by constructing a Vault secret path dynamically based on the name
> of the query user.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
