[
https://issues.apache.org/jira/browse/DRILL-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566158#comment-17566158
]
ASF GitHub Bot commented on DRILL-8158:
---------------------------------------
jnturton commented on code in PR #2590:
URL: https://github.com/apache/drill/pull/2590#discussion_r919648732
##########
distribution/src/assemble/component.xml:
##########
@@ -245,10 +245,6 @@
<source>../NOTICE</source>
<outputDirectory />
</file>
- <file>
- <source>../git.properties</source>
Review Comment:
@vvysotskyi thanks that slipped through because I decided to start from the
existing commit in the original PR for this.
> Remove non-reproducible build outputs
> -------------------------------------
>
> Key: DRILL-8158
> URL: https://issues.apache.org/jira/browse/DRILL-8158
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.20.0
> Reporter: Herve Boutemy
> Assignee: James Turton
> Priority: Major
> Fix For: 1.20.2
>
>
> For context see [1] and [2]. The git-commit-id plugin includes information
> like build host, email and time which is not compatible with a reproducible
> build. Drill's built in sys.version table will return the build email and
> time if they are present in the build's git.properties file so these columns
> must be deprecated. Other useful Git-related information is retained.
> In accompanying commits, some Kerberos unit test fixes are applied, and the
> tests reenabled, and some updates to Release.md are included.
> [1] [https://maven.apache.org/guides/mini/guide-reproducible-builds.html]
> [2]
> [https://github.com/jvm-repo-rebuild/reproducible-central#org.apache.drill:drill-root]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
