[
https://issues.apache.org/jira/browse/DRILL-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601340#comment-17601340
]
ASF GitHub Bot commented on DRILL-8295:
---------------------------------------
jnturton commented on code in PR #2641:
URL: https://github.com/apache/drill/pull/2641#discussion_r964935897
##########
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##########
@@ -189,6 +191,8 @@ public void eval() {
rowWriter.start();
if (jsonLoader.parser().next()) {
rowWriter.save();
+ } else {
Review Comment:
@cgivre yes, you're right. I tried a couple of things. First I provided a
JSON response that would normally produce 64k+1 rows if queried to http_get but
it looked to me like it was being handled in a single batch since, I guess, the
row count of the query is still 1. I then wrote a query to `SELECT
http_get(some simple JSON)` from a mock table containing 64k+1 rows. This
overwhelms the okhttp3 mock server and fails with a timeout. I'm not sure if
there some other test to try here?
> Probable resource leak in the HTTP storage plugin
> -------------------------------------------------
>
> Key: DRILL-8295
> URL: https://issues.apache.org/jira/browse/DRILL-8295
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - HTTP
> Affects Versions: 1.20.2
> Reporter: James Turton
> Assignee: James Turton
> Priority: Major
> Fix For: 1.20.3
>
>
> It looks to me like SimpleHttp does not always close objects created using
> OkHttp, e.g. line 378.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
