[ https://issues.apache.org/jira/browse/DRILL-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601749#comment-17601749 ]
ASF GitHub Bot commented on DRILL-8302: --------------------------------------- pjfanning opened a new pull request, #2645: URL: https://github.com/apache/drill/pull/2645 ## Description Code tidy-up. ## Documentation (Please describe user-visible changes similar to what should appear in the Drill documentation.) ## Testing (Please describe how this PR has been tested.) > tidy up some char conversions > ----------------------------- > > Key: DRILL-8302 > URL: https://issues.apache.org/jira/browse/DRILL-8302 > Project: Apache Drill > Issue Type: Improvement > Reporter: PJ Fanning > Priority: Major > > As part of DRILL-8301, I spotted code that could be tidied up. The aim of > this issue is to reduce the size of DRILL-8301 without introducing changes to > the char encodings. > * uses of a pattern like `new String("aaaa")` - IntelliJ and other tools > highlight this as unnecessary > * uses of `new String(bytes, StandardCharsets.UTF_8.name())` - better to use > `new String(bytes, StandardCharsets.UTF_8)` > * use Base64 encodeToString instead of case where we encode to bytes and > then do our own encoding of those bytes to a String > * Replace existing code with `Charset.forName("UTF-8")` to use > `StandardCharsets.UTF_8` -- This message was sent by Atlassian Jira (v8.20.10#820010)