[
https://issues.apache.org/jira/browse/DRILL-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611142#comment-17611142
]
ASF GitHub Bot commented on DRILL-8323:
---------------------------------------
pjfanning commented on code in PR #2663:
URL: https://github.com/apache/drill/pull/2663#discussion_r983816977
##########
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestStringDistanceFunctions.java:
##########
@@ -59,15 +59,15 @@ public void testJaccardDistance() throws Exception {
double result = queryBuilder()
.sql("select jaccard_distance( 'Big car', 'red car' ) as distance FROM
(VALUES(1))")
.singletonDouble();
- assertEquals(0.56, result, 0.0);
+ assertEquals(0.5555555555555556, result, 0.0);
}
@Test
public void testJaroDistance() throws Exception {
double result = queryBuilder()
.sql("select jaro_distance( 'Big car', 'red car' ) as distance FROM
(VALUES(1))")
.singletonDouble();
- assertEquals(0.7142857142857143, result, 0.0);
+ assertEquals(0.2857142857142857, result, 0.0);
}
Review Comment:
change needed because of https://issues.apache.org/jira/browse/TEXT-191
> upgrade commons-text to 1.10.0
> ------------------------------
>
> Key: DRILL-8323
> URL: https://issues.apache.org/jira/browse/DRILL-8323
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: PJ Fanning
> Priority: Major
>
> [https://commons.apache.org/proper/commons-text/changes-report.html#a1.10.0]
> https://issues.apache.org/jira/browse/TEXT-191 affects one of our tests - I
> have fixed the test in my PR - the old expected value was wrong due to
> TEXT-191 bug
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
