[
https://issues.apache.org/jira/browse/DRILL-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615280#comment-17615280
]
ASF GitHub Bot commented on DRILL-8314:
---------------------------------------
vvysotskyi commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r991589179
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java:
##########
@@ -34,12 +34,22 @@ public interface StoragePluginRegistry extends
Iterable<Map.Entry<String, Storag
@SuppressWarnings("serial")
public static class PluginException extends Exception {
+
+ public final StoragePlugin plugin;
Review Comment:
Looks like it is not used now
##########
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStoragePlugin.java:
##########
@@ -108,19 +109,22 @@ public Optional<DataSource> getDataSource(UserCredentials
userCredentials) {
));
}
- public SqlDialect getDialect(DataSource dataSource) {
- return JdbcSchema.createDialect(
- SqlDialectFactoryImpl.INSTANCE,
- dataSource
- );
+ public synchronized SqlDialect getDialect(UserCredentials userCredentials) {
+ if (sqlDialect == null) {
Review Comment:
Please use double-check to avoid extra overhead caused by synchronization
for most of the calls when the `sqlDialect` is already created.
> Add support for automatically retrying and disabling broken storage plugins
> ---------------------------------------------------------------------------
>
> Key: DRILL-8314
> URL: https://issues.apache.org/jira/browse/DRILL-8314
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
> Affects Versions: 1.20.2
> Reporter: James Turton
> Assignee: James Turton
> Priority: Minor
> Fix For: 2.0.0
>
>
> Enabled storage plugins may malfunction for different reasons, e.g. they have
> been misconfigured or their remote data source has gone offline. Depending on
> the plugin's implementation, this could cause it to fail to return optimizer
> rules or register schemas. In some cases this can have a wider impact, e.g.
> unconditioned queries against the info schema will fail if a single plugin is
> failing in registerSchemas.
> Rather than us swallowing such errors and silently returning a subset of
> results, this Jira proposes new features that allow firstly for the retrying
> of attempts to get rules or schemas from a plugin and secondly for a plugin
> to be automatically disabled after the configured maximum number of attempts
> have failed. A broken plugin will still cause a query failure but the user
> will be informed that the plugin has been disabled as a result. Knowing what
> has just happened, the user can choose to reissue the query knowing that the
> broken plugin is now disabled or they might choose to investigate the problem
> affecting the broken plugin instead.
> These new features are optional and can be disabled using new SYSTEM options.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
