[
https://issues.apache.org/jira/browse/DRILL-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624512#comment-17624512
]
ASF GitHub Bot commented on DRILL-8340:
---------------------------------------
cgivre commented on code in PR #2689:
URL: https://github.com/apache/drill/pull/2689#discussion_r1005763509
##########
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestNearestDateFunctions.java:
##########
@@ -149,7 +149,7 @@ public void testReadException() throws Exception {
run(query);
fail();
} catch (DrillRuntimeException e) {
- assertTrue(e.getMessage().contains("[BAD_DATE] is not a valid time
statement. Expecting: " +
Arrays.asList(NearestDateUtils.TimeInterval.values())));
+ assertTrue(e.getMessage().contains("[BAD_DATE] is not a valid time
statement. Expecting: " +
Arrays.asList(DateConversionUtils.TimeInterval.values())));
Review Comment:
I was trying to consolidate all the non-core date/time UDFs and their tests
into fewer classes. I'll refactor so that's the case.
> Add Additional Date Manipulation Functions (Part 1)
> ---------------------------------------------------
>
> Key: DRILL-8340
> URL: https://issues.apache.org/jira/browse/DRILL-8340
> Project: Apache Drill
> Issue Type: Improvement
> Components: Functions - Drill
> Affects Versions: 1.20.2
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 2.0.0
>
>
> This PR adds several utility functions to facilitate working with dates and
> times. These are modeled after the date/time functionality in MySQL.
> Specifically this adds:
> * YEARWEEK(<date>): Returns an int of year week. IE (202002)
> * TIME_STAMP(<date string>): Converts most anything that looks like a date
> string into a timestamp.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
