[ 
https://issues.apache.org/jira/browse/DRILL-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631053#comment-17631053
 ] 

ASF GitHub Bot commented on DRILL-8354:
---------------------------------------

cgivre commented on code in PR #2703:
URL: https://github.com/apache/drill/pull/2703#discussion_r1017891449


##########
exec/java-exec/src/test/resources/jsoninput/is_empty_tests.json:
##########
@@ -0,0 +1,27 @@
+[
+  {
+    "numeric_col": 1.3,
+    "text_col": "text",
+    "list_col": [
+      "v1", "v2"
+    ],
+   "map_column": {
+    "field1": "value1",
+    "field2": "value2",
+    "nested_map": {
+      "nested_field1": "nested_value1",
+      "nested_field2" : "nested_value2"
+      }
+    }
+  },{
+    "numeric_col": 2.3,
+    "text_col": "",
+    "list_col": [],
+    "map_column": {}
+  },{
+    "numeric_col": null,
+    "text_col": null,
+    "list_col": [],
+    "map_column": {}
+  }

Review Comment:
   @jnturton Done!  I addressed your review comments.  Thanks for the quick 
review!





> Add IS_EMPTY Function.
> ----------------------
>
>                 Key: DRILL-8354
>                 URL: https://issues.apache.org/jira/browse/DRILL-8354
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Functions - Drill
>    Affects Versions: 1.20.2
>            Reporter: Charles Givre
>            Assignee: Charles Givre
>            Priority: Major
>             Fix For: 2.0.0
>
>
> When analyzing data, there is currently no single function to evaluate 
> whether a given field is empty.  With scalar fields, this can be accomplished 
> with the `IS NOT NULL` operator, but with complex fields, this is more 
> challenging as complex fields are never null. 
> This PR adds a UDF called IS_EMPTY() which accepts any type of field and 
> returns true if the field does not contain data.  
>  
> In the case of scalar fields, if the field is `null` this returns true.  In 
> the case of complex fields, which can never be `null`, in the case of lists, 
> the function returns true if the list is empty.  In the case of maps, it 
> returns true if all of the map's fields are unpopulated. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to