[
https://issues.apache.org/jira/browse/DRILL-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645555#comment-17645555
]
ASF GitHub Bot commented on DRILL-8364:
---------------------------------------
jnturton commented on code in PR #2714:
URL: https://github.com/apache/drill/pull/2714#discussion_r1044992012
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java:
##########
@@ -82,13 +83,21 @@ public class FileSystemSchema extends AbstractSchema {
public FileSystemSchema(String name, SchemaConfig schemaConfig) throws
IOException {
super(Collections.emptyList(), name);
final DrillFileSystem fs =
ImpersonationUtil.createFileSystem(schemaConfig.getUserName(),
plugin.getFsConf());
+ // Set OAuth Information
+ OAuthConfig oAuthConfig = plugin.getConfig().oAuthConfig();
+ if (oAuthConfig != null) {
+ OAuthEnabledFileSystem underlyingFileSystem = (OAuthEnabledFileSystem)
fs.getUnderlyingFs();
Review Comment:
Last question from me - would it work out cleaner to make
OAuthEnabledFileSystem inherit from DrillFileSystem? In particular, could that
elimnate this new getUnderlyingFs method()? Or it would cause trouble elsewhere?
> Add Support for OAuth Enabled File Systems
> ------------------------------------------
>
> Key: DRILL-8364
> URL: https://issues.apache.org/jira/browse/DRILL-8364
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - File
> Affects Versions: 1.20.2
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 2.0.0
>
>
> Currently Drill supports reading from file systems such as HDFS, S3 and
> others that use token based authentication. This PR extends Drill's plugin
> architecture so that Drill can connect with other file systems which use
> OAuth 2.0 for authentication.
> This PR also adds support for Drill to query Box.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
