[
https://issues.apache.org/jira/browse/DRILL-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646689#comment-17646689
]
ASF GitHub Bot commented on DRILL-8369:
---------------------------------------
pjfanning commented on code in PR #2718:
URL: https://github.com/apache/drill/pull/2718#discussion_r1047285109
##########
contrib/format-deltalake/src/main/java/org/apache/drill/exec/store/delta/format/DeltaFormatPluginConfig.java:
##########
@@ -18,15 +18,55 @@
package org.apache.drill.exec.store.delta.format;
import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonTypeName;
+import org.apache.drill.common.PlanStringBuilder;
import org.apache.drill.common.logical.FormatPluginConfig;
+import java.util.Objects;
+
@JsonTypeName(DeltaFormatPluginConfig.NAME)
public class DeltaFormatPluginConfig implements FormatPluginConfig {
public static final String NAME = "delta";
+ private final Long version;
+ private final Long timestamp;
+
@JsonCreator
- public DeltaFormatPluginConfig() {
+ public DeltaFormatPluginConfig(@JsonProperty("version") Long version,
Review Comment:
I dislike the need for all the annotations but Jackson insists on when you
go down certain paths.
If you put back the empty constructor as well as having the 2 param
constructor, you will possibly find that you don't need the JsonCreator and
JsonProperty annotations any more.
Jackson seems to prefer to use the no params constructor and to use
reflection to set the values on the fields.
> Add support for querying DeltaLake snapshots by version
> -------------------------------------------------------
>
> Key: DRILL-8369
> URL: https://issues.apache.org/jira/browse/DRILL-8369
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Vova Vysotskyi
> Assignee: Vova Vysotskyi
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
