[
https://issues.apache.org/jira/browse/DRILL-8378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652517#comment-17652517
]
ASF GitHub Bot commented on DRILL-8378:
---------------------------------------
jnturton opened a new pull request, #2730:
URL: https://github.com/apache/drill/pull/2730
# [DRILL-8378](https://issues.apache.org/jira/browse/DRILL-8378): Support
doing Maven releases using modern JDKs
## Description
While [DRILL-8113](https://issues.apache.org/jira/browse/DRILL-8113) enabled
the building of Drill using a modern JDK, more work is required to enable a
Maven release of Drill using a modern JDK. Presently, the Maven Release Plugin
will fail on Javadoc generation when run with a newer JDK while it succeeds
with JDK 8. The failures are due to dependencies missing from the Maven Javadoc
Plugin's config which I assume get treated with a more lenient "warn and skip"
policy in the javadoc tool shipped with JDK 8 but cause errors in newer JDKs
(in my case OpenJDK 17).
In particular, the presence of the `sourcepath` property in the javadoc
plugin's config in the root pom causes the default javadoc:javadoc goal to try
to generate docs for our src/test packages. Unlike the javadoc:test-javadoc,
the javadoc:javadoc goal does not inherit dependencies declared with `test`
scope so it fails to resolve those.
## Documentation
N/A
## Testing
Successfully run maven release:prepare using OpenJDK 17.
Successfully run mvn javadoc:javadoc in the Drill root module using OpenJDK
17 with HTML output generated under each module's target/site/apidocs directory.
> Support doing Maven releases using modern JDKs
> ----------------------------------------------
>
> Key: DRILL-8378
> URL: https://issues.apache.org/jira/browse/DRILL-8378
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.20.2
> Reporter: James Turton
> Assignee: James Turton
> Priority: Minor
> Fix For: 1.21.0
>
>
> While DRILL-8113 enabled the building of Drill using a modern JDK, more work
> is required to enable a Maven release of Drill using a modern JDK. Presently,
> the Maven Release Plugin will fail on Javadoc generation when run with a
> newer JDK while it succeeds with JDK 8. The failures are due to dependencies
> missing from the Maven Javadoc Plugin's config which I assume get treated
> with a more lenient "warn and skip" policy in the javadoc tool shipped with
> JDK 8 but cause errors in newer JDKs (in my case OpenJDK 17).{-}{-}
> In particular, the presence of the sourcepath property in the javadoc
> plugin's config in the root pom causes the default javadoc:javadoc goal to
> try to generate docs for our src/test packages. Unlike the
> javadoc:test-javadoc, the javadoc:javadoc goal does not inherit dependencies
> declared with test scope.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
