[
https://issues.apache.org/jira/browse/DRILL-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17688476#comment-17688476
]
ASF GitHub Bot commented on DRILL-8117:
---------------------------------------
jnturton opened a new pull request, #2756:
URL: https://github.com/apache/drill/pull/2756
# [DRILL-8117](https://issues.apache.org/jira/browse/DRILL-8117): Upgrade
unit tests to the cluster fixture framework
## Description
Upgrades various unit tests to the cluster fixture framework and replaces
other instances of deprecated code usage.
Methods client.alterSession() and client.alterSystem() run sql silently
which would not throw exception, so it doesn't match the purpose for some test
cases. And I still keep using run() here for consistence.
For `TestInboundImpersonation`
Because cluster fixture save client properties even client closed, use a
dedicated cluster fixture for each test case to ensure the client fixture has
clean properties.
For `TestImpersonationMetadata`
Only use one cluster from test start to the end will induce buffer overflow.
So change BeforeClass to Before to start a new cluster for each test case.
## Documentation
N/A
## Testing
Existing unit tests.
> Upgrade unit tests to the cluster fixture framework
> ---------------------------------------------------
>
> Key: DRILL-8117
> URL: https://issues.apache.org/jira/browse/DRILL-8117
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.20.1
> Reporter: Jingchuan Hu
> Assignee: James Turton
> Priority: Major
> Fix For: 1.21.0
>
>
> Upgrade various unit tests to the cluster fixture framework and replace other
> instances of deprecated code usage.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
