[
https://issues.apache.org/jira/browse/DRILL-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701101#comment-17701101
]
ASF GitHub Bot commented on DRILL-8410:
---------------------------------------
jnturton commented on PR #2775:
URL: https://github.com/apache/drill/pull/2775#issuecomment-1471784565
It would probably be possible to create patch-based version of this PR that
makes use of
[maven-patch-plugin](https://maven.apache.org/plugins/maven-patch-plugin/) and
has a much lower line count. On the other hand it's not inconceivable that we
decide to maintain our Parser.jj.
> Upgrade to Calcite 1.34
> -----------------------
>
> Key: DRILL-8410
> URL: https://issues.apache.org/jira/browse/DRILL-8410
> Project: Apache Drill
> Issue Type: Improvement
> Components: library
> Affects Versions: 1.21.0
> Reporter: James Turton
> Assignee: James Turton
> Priority: Major
> Fix For: 1.21.1
>
>
> Calcite 1.34 includes
> # a fix for the currently broken date_trunc function in Drill
> # support for a new QUALIFY clause in windows functions
> # incompatible core parser grammar changes that break date_diff in Drill.
> Because of (3), Drill needs to make temporary use of a modified Parser.jj
> until Calcite backs out the mentioned parser changes. See the linked Calcite
> issues for more details.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
