[
https://issues.apache.org/jira/browse/DRILL-8430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721065#comment-17721065
]
ASF GitHub Bot commented on DRILL-8430:
---------------------------------------
pjfanning commented on code in PR #2800:
URL: https://github.com/apache/drill/pull/2800#discussion_r1189058399
##########
common/src/test/java/org/apache/drill/test/DrillTest.java:
##########
@@ -37,11 +38,10 @@
public class DrillTest extends BaseTest {
- protected static final ObjectMapper objectMapper;
+ private static final ObjectMapper objectMapper =
JacksonUtils.createObjectMapper();
Review Comment:
Some tests were using this mapper and modifying it - which seems like a
dangerous thing to do because other tests will be affected by the modified
mapper. I've changed the tests that used this mapper to create their own
separate mappers.
> add factory method for creating Jackson ObjectMappers
> -----------------------------------------------------
>
> Key: DRILL-8430
> URL: https://issues.apache.org/jira/browse/DRILL-8430
> Project: Apache Drill
> Issue Type: Task
> Components: Server
> Reporter: PJ Fanning
> Priority: Major
>
> See https://issues.apache.org/jira/browse/DRILL-8415
> It's useful to keep any customisation of the ObjectMapper creation in 1 place
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
