[
https://issues.apache.org/jira/browse/DRILL-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758547#comment-17758547
]
ASF GitHub Bot commented on DRILL-8453:
---------------------------------------
cgivre commented on code in PR #2824:
URL: https://github.com/apache/drill/pull/2824#discussion_r1304230698
##########
contrib/format-xml/src/test/resources/logback-test.xml:
##########
@@ -0,0 +1,69 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<configuration>
+ <if condition='property("drill.lilith.enable").equalsIgnoreCase("true")'>
+ <then>
+ <appender name="SOCKET"
class="de.huxhorn.lilith.logback.appender.ClassicMultiplexSocketAppender">
+ <Compressing>true</Compressing>
+ <ReconnectionDelay>10000</ReconnectionDelay>
+ <IncludeCallerData>true</IncludeCallerData>
+ <RemoteHosts>${LILITH_HOSTNAME:-localhost}</RemoteHosts>
+ </appender>
Review Comment:
This is a file which should have not been included in the PR. ;-).
> Add XSD Support to XML Reader (Part 1)
> --------------------------------------
>
> Key: DRILL-8453
> URL: https://issues.apache.org/jira/browse/DRILL-8453
> Project: Apache Drill
> Issue Type: Improvement
> Components: Format - XML
> Affects Versions: 1.21.1
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.21.2
>
>
> This PR is a part of a series to add better support for reading XML data to
> Drill. One of the main challenges is that XML data does not have a way of
> inferring data types, nor does it have a way of detecting arrays.
> The only way to do this really well is to have a schema. Some XML files link
> a schema definition file to the data. This PR adds the capability for Drill
> to map XSD schema files into Drill schemas.
> The current plan is as follows: Part 1 of this PR simply adds the reader but
> adds no new user detectable functionality. Part 2 will include the actual
> integration with the XML reader. Part 3 will include the ability to read
> arrays.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
