[
https://issues.apache.org/jira/browse/DRILL-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801757#comment-17801757
]
ASF GitHub Bot commented on DRILL-8468:
---------------------------------------
rymarm commented on PR #2859:
URL: https://github.com/apache/drill/pull/2859#issuecomment-1873939057
> Are the two removed null checks not needed?
@jnturton Yes, they are redundant.
``` java
if (locatorPlugins != null) {
bootstrapPlugins.putAll(locatorPlugins);
}
```
It is redundant, because `StoragePlugins#putAll` himself checks the
argument nullability:
https://github.com/apache/drill/blob/15c446d7e8ebe6d97fc879103e1710d733318c6d/exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/StoragePlugins.java#L114-L117
```java
if (upgraded != null) {
upgraded.putAll(locatorPlugins);
}
```
It is redundant, because `upgraded` is just initialized with a constructor
just a few lines above and not overridden.
> Drill doesn't perform drill.exec.storage.action_on_plugins_override_file
> action
> -------------------------------------------------------------------------------
>
> Key: DRILL-8468
> URL: https://issues.apache.org/jira/browse/DRILL-8468
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.18.0
> Reporter: Maksym Rymar
> Assignee: Maksym Rymar
> Priority: Major
>
> After the Plugin Registry refactoring
> https://issues.apache.org/jira/browse/DRILL-7590, Drill stopped honoring
> {{drill.exec.storage.action_on_plugins_override_file}} property.
> After the refactoring, Drill performs
> {{drill.exec.storage.action_on_plugins_override_file}} action only once, on
> initial storage plugin registry initialization. After the initialization, on
> every next Drill restart, the action will not be performed. It means, that
> after {{storage-plugins-override.conf}} apply, this file is neither renamed
> nor removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
