[ https://issues.apache.org/jira/browse/DRILL-8501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863481#comment-17863481 ]
ASF GitHub Bot commented on DRILL-8501: --------------------------------------- jnturton commented on PR #2921: URL: https://github.com/apache/drill/pull/2921#issuecomment-2211746498 Before I approve, did you consider making these JSON parsing settings parameters of the function itself? It feels odd to me that `store.json.*` settings could influence UDFs too. I'm not sure why they aren't storage plugin config, rather than global config, in the first place... > Json Conversion UDF Not Respecting System JSON Options > ------------------------------------------------------ > > Key: DRILL-8501 > URL: https://issues.apache.org/jira/browse/DRILL-8501 > Project: Apache Drill > Issue Type: Bug > Components: Storage - JSON > Affects Versions: 1.21.2 > Reporter: Charles Givre > Assignee: Charles Givre > Priority: Major > Fix For: 1.22.0 > > > The convert_fromJSON() UDF does not respect the system JSON options of > allTextMode and readAllNumbersAsDouble. > This PR fixes that. -- This message was sent by Atlassian Jira (v8.20.10#820010)