[
https://issues.apache.org/jira/browse/DRILL-8504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888531#comment-17888531
]
ASF GitHub Bot commented on DRILL-8504:
---------------------------------------
jnturton commented on code in PR #2929:
URL: https://github.com/apache/drill/pull/2929#discussion_r1796491808
##########
contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkSchema.java:
##########
@@ -148,8 +183,24 @@ private void registerIndexes() {
registerTable(SPL_TABLE_NAME, new DynamicDrillTable(plugin,
plugin.getName(),
new SplunkScanSpec(plugin.getName(), SPL_TABLE_NAME, plugin.getConfig(),
queryUserName)));
+ Set<String> indexList = null;
// Retrieve and add all other Splunk indexes
- for (String indexName : connection.getIndexes().keySet()) {
+ // First check the cache to see if we have a list of indexes.
+ String nameKey = getNameForCache();
+ if (useCache) {
+ indexList = cache.getIfPresent(nameKey);
+ }
Review Comment:
@cgivre is the cache really storing one Splunk index per key? Here it looks
to me like there's a single cache key derived from the queryUserName and the
plugin name that holds a list of indexes. Or am I just being confused by the
Caffeine API?
> Add Schema Caching to Splunk Plugin
> -----------------------------------
>
> Key: DRILL-8504
> URL: https://issues.apache.org/jira/browse/DRILL-8504
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Splunk
> Affects Versions: 1.21.2
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.22.0
>
>
> See PR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
