[
https://issues.apache.org/jira/browse/DRILL-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063953#comment-18063953
]
ASF GitHub Bot commented on DRILL-8544:
---------------------------------------
cgivre commented on PR #3038:
URL: https://github.com/apache/drill/pull/3038#issuecomment-4020590227
> @cgivre I was thinking more of a test that:
>
> * create a Jackson ObjectMapper instance
> * call writeValueAsString with a representative instance of
HDF5FormatConfig
> * check the JSON string returned includes the values that you want
> * call readVale on the ObjectMapper instance to see if the value round
trips ok (ie the HDF5FormatConfig instance you get returned from readValue
matches the HDF5FormatConfig instance that you started with)
>
> When you start playing with Jackson annotations, that affects what the
serialization and deserialization does and unfortunately, Jackson releases can
change the behaviour when trying to fix bugs.
I added some new unit tests.
> HDF5 Files Ignoring Config Options
> ----------------------------------
>
> Key: DRILL-8544
> URL: https://issues.apache.org/jira/browse/DRILL-8544
> Project: Apache Drill
> Issue Type: Bug
> Components: FOrmat - HDF5
> Affects Versions: 1.20.0, 1.20.1, 1.20.2, 1.20.3, 1.21.1, 1.22.0, 1.21.2
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.23.0
>
>
> The HDF5 Plugin is ignoring certain plugin options. This minor update fixes
> that.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
