[ 
https://issues.apache.org/jira/browse/DRILL-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076923#comment-14076923
 ] 

Parth Chandra commented on DRILL-1197:
--------------------------------------

Hi Xiao,

  I didn't follow what you meant by :
Use socket close operation in handleHandshakeTimeout will trigger
handleRead and singal additional error and problematic in the ODBC driver
What problems does that cause?

Also, after shutdown, is the client's connection still usable? I don't
think it is. If it is not, then we have a much bigger problem. We cannot
allow a client connection to die because the server took too long to
respond!

I think you should split this into two separate changes. The change to have
different timeouts for handshake and query into one commit and the fix for
32-bit timeout into another commit. (And log a JIRA for the latter). I want
to be able to restrict the second fix to its own commit since I'm not sure
of it's overall impact.

Parth










> C++ Client.  Differentiate socket/handshake/query timeout for deadline timer.
> -----------------------------------------------------------------------------
>
>                 Key: DRILL-1197
>                 URL: https://issues.apache.org/jira/browse/DRILL-1197
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Client - C++
>            Reporter: Xiao Meng
>            Assignee: Xiao Meng
>             Fix For: 0.5.0
>
>         Attachments: DRILL-1197.1.patch.txt
>
>
> [#DRILL-852] introduced deadline timer to C++ Client. It use a global setting 
> of timeout for all reading operation. We should differentiate timeout for 
> different operations and also populate the status to client library user.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to