[
https://issues.apache.org/jira/browse/DRILL-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152617#comment-14152617
]
Parth Chandra edited comment on DRILL-1297 at 9/30/14 12:57 AM:
----------------------------------------------------------------
+1
Ship it. (reviewed here: https://reviews.apache.org/r/25806/)
was (Author: parthc):
+1
Ship it.
> Hide Dependencies From Public API to enable using the C++ Client as a DLL
> -------------------------------------------------------------------------
>
> Key: DRILL-1297
> URL: https://issues.apache.org/jira/browse/DRILL-1297
> Project: Apache Drill
> Issue Type: Task
> Components: Client - C++
> Environment: Windows 7
> Reporter: Alexander Zarei
> Assignee: DrillCommitter
> Priority: Blocker
> Fix For: 0.6.0
>
> Attachments: DRILL-1297-patch-1.diff
>
>
> Protobuf dependency is exposed to customers through public API header files.
> In particular, we have built C++ Client as a DLL but when linking it to our
> code, the public API header files do not compile as they expose additional
> dependencies that should be hidden from the costumer code. Especially,
> incubator-drill\contrib\native\client\src\include\drill\protobuf\User.pb.h
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
