[ 
https://issues.apache.org/jira/browse/DRILL-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187803#comment-14187803
 ] 

Aditya Kishore commented on DRILL-1599:
---------------------------------------

Thanks for updating the patch. However, there are couple of issues.

# The patch file name does not confirm to the standard, i.e. 
{{DRILL-<JIRA_NUMBER>....}}
# Is not generated using {{[git 
format-patch|https://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html]}}.

Please see this drill-dev list thread regarding the guidelines for patch 
submission.

http://mail-archives.apache.org/mod_mbox/incubator-drill-dev/201403.mbox/%3CCAKa9qDmK+F1j=qds-x9ujouggihfg4wk7x_xpm_kndnt7tj...@mail.gmail.com%3E

> Drill FileSystemPlugin need getOptimizerRules() method to get optimizer rules 
> from format plugin
> ------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-1599
>                 URL: https://issues.apache.org/jira/browse/DRILL-1599
>             Project: Apache Drill
>          Issue Type: Task
>            Reporter: Anbang Xu
>         Attachments: FileSystemPlugin.java.v2.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to