[
https://issues.apache.org/jira/browse/DRILL-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197891#comment-14197891
]
Hanifi Gunes edited comment on DRILL-1548 at 11/5/14 8:40 AM:
--------------------------------------------------------------
Thanks for the review & updates Aditya. Interpreter seems neither under active
development nor in use so I would think that disabling or even completely
removing it from default build should be just fine. Also given that these are
optional switches to make builds faster imho individually disabling contrib
should not be a problem either.
Regarding patch conventions, have you seen this
[guideline|https://cwiki.apache.org/confluence/display/DRILL/Apache+Drill+Contribution+Guidelines#ApacheDrillContributionGuidelines-Creatingapatch]?
If this doc is outdated/missing some info, we should file a jira to update it
as well.
ps: I have seen MNG-4565 as well. To me, it looks like a long standing maven
bug. My understanding is that matchers never meant to be OR'ed nor maven has a
mechanism to OR multiple conditionals of the same type such like multiple
properties, which was what I needed btw. [maven
doc|http://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html]
was (Author: hgunes):
Thanks for the review & updates Aditya. Interpreter seems neither under active
development nor in use so I would think that disabling or even completely
removing it from default build should be just fine. Also given that these are
optional switches to make builds faster imho individually disabling contrib
should not be a problem either.
Regarding patch conventions, have you seen this
[guideline|https://cwiki.apache.org/confluence/display/DRILL/Apache+Drill+Contribution+Guidelines#ApacheDrillContributionGuidelines-Creatingapatch]?
If this doc is outdated/missing some info, we should file a jira to update it
as well.
ps: I have seen MNG-4565 as well. To me, it looks like a long standing maven
bug. My understanding is that matchers never meant to be OR'ed nor maven has a
mechanism to OR multiple conditionals of the same type such like multiple
properties, which was what I needed btw. [maven
doc|http://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.htm]
> Remove jdbc-all from default build
> ----------------------------------
>
> Key: DRILL-1548
> URL: https://issues.apache.org/jira/browse/DRILL-1548
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Hanifi Gunes
> Assignee: Steven Phillips
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: DRILL-1548-Remove-jdbc-all-from-default-build.patch,
> DRILL-1548.1.patch.txt, DRILL-1548.patch
>
>
> Currently, jdbc-all module is built each and every time maven build is
> started. Building jdbc-all is time consuming and outputs verbose messages
> making it hard to track lines of interest. This issue proposes to remove
> jdbc-all from the default maven build possibly moving it to apache build.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
