[
https://issues.apache.org/jira/browse/EAGLE-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694917#comment-15694917
]
ASF GitHub Bot commented on EAGLE-800:
--------------------------------------
Github user wujinhu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/684#discussion_r89567435
--- Diff:
eagle-jpm/eagle-jpm-util/src/main/java/org/apache/eagle/jpm/util/jobrecover/RunningJobManager.java
---
@@ -49,12 +53,21 @@ private CuratorFramework newCurator(String zkQuorum,
int zkSessionTimeoutMs, int
);
}
- public RunningJobManager(String zkQuorum, int zkSessionTimeoutMs, int
zkRetryTimes, int zkRetryInterval, String zkRoot) {
+ public RunningJobManager(String zkQuorum, int zkSessionTimeoutMs, int
zkRetryTimes, int zkRetryInterval, String zkRoot, String siteId) {
--- End diff --
I think pass the lock path to utility class directly will be better since
utility class does not need to know how to make the lock path.
How to define the lock path is decided by applications
> Use InterProcessMutex to sync operation in RunningJobManager
> ------------------------------------------------------------
>
> Key: EAGLE-800
> URL: https://issues.apache.org/jira/browse/EAGLE-800
> Project: Eagle
> Issue Type: Improvement
> Reporter: JiJun Tang
> Assignee: JiJun Tang
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
