Github user wujinhu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/700#discussion_r90372961
--- Diff:
eagle-jpm/eagle-jpm-util/src/main/java/org/apache/eagle/jpm/util/Utils.java ---
@@ -116,6 +116,6 @@ public static long parseMemory(String memory) {
public static String makeLockPath(String zkrootWithSiteId) {
Preconditions.checkArgument(StringUtils.isNotBlank(zkrootWithSiteId),
"zkrootWithSiteId must not be blank");
- return zkrootWithSiteId.toLowerCase() + "/locks";
+ return "/locks" + zkrootWithSiteId.toLowerCase();
--- End diff --
As I mentioned, if we have structure like
zkRoot/locks
zkRoot/jobs/1
zkRoot/jobs/2
yarnAppIds will be curator.getChildren().forPath(this.zkRoot + "/jobs");
so, you need to do a simple refactor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
