Github user r7raul1984 commented on the issue:

    https://github.com/apache/incubator-eagle/pull/699
  
    This refactor has the following advantages:
    -   Reuseability
    Other object which have RouteSpec instance can reuse the makeSSS and 
makeSRS logic.
    
    -   Readability
    I think the logic is domain logic. So the logic that should be in a domain 
object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to