[jira] [Commented] (FINERACT-662) Activation date field should throw error when edit center

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FINERACT-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684744#comment-16684744
 ] 

ASF GitHub Bot commented on FINERACT-662:
-----------------------------------------

ShruthiRajaram closed pull request #490: FINERACT-662 activation date null check
URL: https://github.com/apache/fineract/pull/490
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java
 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java
index a40aad7e8..b0874ce7d 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java
@@ -46,10 +46,10 @@
 import org.apache.fineract.infrastructure.codes.domain.CodeValue;
 import org.apache.fineract.infrastructure.core.api.JsonCommand;
 import org.apache.fineract.infrastructure.core.data.ApiParameterError;
+import 
org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
 import 
org.apache.fineract.infrastructure.core.exception.GeneralPlatformDomainRuleException;
 import 
org.apache.fineract.infrastructure.core.exception.PlatformApiDataValidationException;
 import org.apache.fineract.infrastructure.core.service.DateUtils;
-import 
org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
 import 
org.apache.fineract.infrastructure.security.service.RandomPasswordGenerator;
 import org.apache.fineract.organisation.office.domain.Office;
 import org.apache.fineract.organisation.staff.domain.Staff;
@@ -334,7 +334,9 @@ public boolean isPending() {
             actualChanges.put(GroupingTypesApiConstants.localeParamName, 
localeAsInput);
 
             final LocalDate newValue = 
command.localDateValueOfParameterNamed(GroupingTypesApiConstants.activationDateParamName);
-            this.activationDate = newValue.toDate();
+                       if (newValue != null) {
+                               this.activationDate = newValue.toDate();
+                       }
         }
         
         if 
(command.isChangeInStringParameterNamed(GroupingTypesApiConstants.accountNoParamName,
 this.accountNumber)) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Activation date field should throw error when edit center
> ---------------------------------------------------------
>
>                 Key: FINERACT-662
>                 URL: https://issues.apache.org/jira/browse/FINERACT-662
>             Project: Apache Fineract
>          Issue Type: Bug
>          Components: Organization
>    Affects Versions: 1.1.0
>            Reporter: Santosh Math
>            Assignee: Shruthi  M R
>            Priority: Major
>             Fix For: 1.2.0
>
>         Attachments: s22.png
>
>
> *Steps to Reproduce*
> Create center, then edit
> empty activation date, submit, nothing happen
> *Expected Behaviour*
> should show error which shows its mandatory, like when creating center.
>  
> Refer the screenshot. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)