[
https://issues.apache.org/jira/browse/FINERACT-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881802#comment-16881802
]
Michael Vorburger.ch edited comment on FINERACT-780 at 7/10/19 7:46 AM:
------------------------------------------------------------------------
{quote}What exactly does this test do? I do not know about this feature.{quote}
No clue. Perhaps you can "reverse engineer" it, just from looking at the test?
I also find that checking {{git log}} of tests, and its code under test, often
helps. Searching this Jira and the Fineract Confluence Wiki may also have some
references. Or just ask on the mailing list "hey does anyone have any pointers
what the ... functionality actually does" is fair game I guess.
was (Author: vorburger):
{quote}What exactly does this test do? I do not know about this feature.\{quote}
No clue. Perhaps you can "reverse engineer" it, just from looking at the test?
I also find that checking {{git log}} of tests, and its code under test, often
helps. Searching this Jira and the Fineract Confluence Wiki may also have some
references. Or just ask on the mailing list "hey does anyone have any pointers
what the ... functionality actually does" is fair game I guess.
> HookIntegrationTest is flaky
> ----------------------------
>
> Key: FINERACT-780
> URL: https://issues.apache.org/jira/browse/FINERACT-780
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger.ch
> Priority: Major
>
> Our org.apache.fineract.integrationtests.HookIntegrationTest seems to be
> "flaky" and occassionally arbitrary fails.
> This seems to have happened e.g. in
> https://github.com/apache/fineract/pull/557 as well as again in
> https://github.com/apache/fineract/pull/607.
> I suspect it's related to this in the code of that test:
> {code:java}
> // Subject to https://echo-webhook.herokuapp.com being up
> // See
> //
> http://www.jamesward.com/2014/06/11/testing-webhooks-was-a-pain-so-i-fixed-the-glitch
> final String payloadURL =
> "http://echo-webhook.herokuapp.com:80/Z7RXoCBdLSFMDrpn?";;
> this.hookHelper.createHook(payloadURL);
> {code}
> In an ideal world, even an integration test should not depend on an external
> service running on some arbitrary 3rd party website.
> What someone probably could do is to instead start some sort of Echo Server
> written in Java in-process as part of that test. Something like this may
> already exist as a library somewhere, or otherwise it probably wouldn't be
> terribly hard to write it.
> If this happens more often, perhaps just temporarily adding an {{@Igore}} for
> this test would be in order (until someone can do above).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
