[ 
https://issues.apache.org/jira/browse/FINCN-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007290#comment-17007290
 ] 

Juhan Aasaru commented on FINCN-196:
------------------------------------

This is my personal feedback. I think this could be implemented. In order to 
remain backwards compatible I would suggest that the caller has two options:

a) the caller of entrypoint.sh could define following variables in evnironment 
before executing entrypoint.sh:
$POSTGRESQL_PASSWORD
$POSTGRESQL_HOST
$POSTGRESQL_USER
$CASSANDRA_CLUSTER_USER
$CASSANDRA_CLUSTER_PASSWORD
$CASSANDRA_HOST

b) the caller could also not define the variables and in this case 
entrypoints.sh should default values should to same values as here: 
[https://github.com/apache/fineract-cn-docker-compose/blob/master/env_variables]
so the caller wouldn't always need to define the values.

 

> Check infrastructure availablility before micro service startup
> ---------------------------------------------------------------
>
>                 Key: FINCN-196
>                 URL: https://issues.apache.org/jira/browse/FINCN-196
>             Project: Fineract Cloud Native
>          Issue Type: Improvement
>            Reporter: Juhan Aasaru
>            Priority: Major
>
>  
> For each micro service
>  # create 
> [entrypoint.sh|https://github.com/apache/fineract-cn-identity/compare/develop...fintecheando:develop#diff-b958f585a04af5ee2087610ea7180f34]
>  and make it call "java -jar microservice.jar" but before that check that 
> Postgres and Cassandra (and Eureka and ActiveMq) are running
>  # make the Dockerfile call entripoint.sh instead of directly starting the 
> jar.
> Example: 
> [https://github.com/apache/fineract-cn-identity/commit/5db1578b88348ad448d0e07607b32bc3b94798bc]
> This idea was proposed by [~Fintecheando] here: 
> https://issues.apache.org/jira/browse/FINCN-189?focusedCommentId=17007232&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17007232
>  (part one)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to