[
https://issues.apache.org/jira/browse/FINERACT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151789#comment-17151789
]
Awasum Yannick commented on FINERACT-1079:
------------------------------------------
This turn out to be a disaster as [~ptuomola] pointed out here:
[https://github.com/apache/fineract/pull/1155#issuecomment-654017489]
I wonder if we should even do this? or just leave the source code as such. I
see there is something from our fellow Apache project, Apache Beam:
[https://cwiki.apache.org/confluence/display/BEAM/Spotless+pre-commit], should
we include this to manually be added locally by Devs?
Should just close this and say its not worth it? Let me not try to optimize
where its not needed. But every Developer should run tasks build, bootRun or
IntegrationTest before commit their changes. Maybe we should not deal with this.
> Run Task spotlessApply before commit (Pre-commit)?
> --------------------------------------------------
>
> Key: FINERACT-1079
> URL: https://issues.apache.org/jira/browse/FINERACT-1079
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Awasum Yannick
> Priority: Minor
> Fix For: 1.4.0
>
>
> Developers consistently have problems manually running the spotlessApply task
> after coding changes... See: [https://github.com/apache/fineract/pull/1151]
> and [https://github.com/apache/fineract/pull/1148]
> maybe we should just run spotlessApply just before compilation and skip the
> tasks to check for spotless failures? Or we run both of them: Run
> spotlessApply before spotlessCheck (seems wasteful). Is this a good idea? I
> wonder?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
