[
https://issues.apache.org/jira/browse/FINERACT-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164959#comment-17164959
] Manthan Surkar commented on FINERACT-942: ----------------------------------------- [~vorburger] sure, 1. https://github.com/apache/fineract/blob/b61957acb20ede94bedd05edc95a505bc59ba513/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/HookIntegrationTest.java#L79-L92 2. https://github.com/apache/fineract/blob/b61957acb20ede94bedd05edc95a505bc59ba513/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/HookIntegrationTest.java#L93-L100 *3. * https://github.com/apache/fineract/blob/c529fdf58c335adb4dd938b0551f7e355e9eb56d/fineract-provider/src/main/java/org/apache/fineract/batch/command/internal/DisburseLoanCommandStrategy.java#L81-L93 and https://github.com/apache/fineract/blob/c529fdf58c335adb4dd938b0551f7e355e9eb56d/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDomainServiceImpl.java#L233-L235 *4.* https://github.com/apache/fineract/blob/2323450e71d1508e6ff218d48b856aefa04542d0/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientEntityImportHandler.java#L194-L228 > Make Checkstyle detect bad logging anti-patterns (and fix problems found) > ------------------------------------------------------------------------- > > Key: FINERACT-942 > URL: https://issues.apache.org/jira/browse/FINERACT-942 > Project: Apache Fineract > Issue Type: Improvement > Reporter: Michael Vorburger > Assignee: Manthan Surkar > Priority: Major > Fix For: 1.4.0 > > > A particularly useful part of FINERACT-821, helping to detect real errors in > Fineract and not just formating, would be to enable the following in > fineract-provider/config/checkstyle/checkstyle.xml, and fix any problems that > this finds: > 1. RegexpSinglelineJava / printStackTrace > 2. IllegalCatch, IllegalThrows, MutableException, > AvoidHidingCauseExceptionCheck > 3. > [EmptyCatchBlock|https://checkstyle.sourceforge.io/config_blocks.html#EmptyCatchBlock] > Nota bene that we already have FINERACT-696, but this is complementary to > that. > One thing this should detect is e.g. the bad wrong emtpy > catch(MessagingException e) in EmailMessageJobEmailServiceImpl. > It may lead to more of FINERACT-932, which would be a Good Thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
