[ 
https://issues.apache.org/jira/browse/FINERACT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185053#comment-17185053
 ] 

Chinmay Kulkarni commented on FINERACT-1101:
--------------------------------------------

Okay. I have raised a backport PR: 
[https://github.com/apache/fineract/pull/1283] for this.

> Swagger CodeGen Test Build using Gradle instead of Maven
> --------------------------------------------------------
>
>                 Key: FINERACT-1101
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1101
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger
>            Assignee: Chinmay Kulkarni
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> Looking at [https://travis-ci.org/github/apache/fineract/builds/714158191] 
> for [https://github.com/apache/fineract/pull/1228] for FINERACT-838, I've 
> noticed that the Swagger Client Code Generation seems  to be built using 
> Maven {{mvn}}... but on {{docs/developers/swagger/client.md}} we document the 
> use of Gradle. This seems inconsistent, and requiring Fineract developers to 
> have Maven installed just for this may be unnecessary? 
> [~Grandolf49] was there a particular reason why you chose to build the client 
> using Maven instead of Gradle on Travis in your PR? If none, would you be 
> willing to raise a PR to change that?
> If that is not possible, the Travis CI should should at least use the Maven 
> Wrapper {{./mvnw}} instead of {{mvn}}. And we should add Caching of Maven 
> artifacts in addition to Gradle to the Travis CI configuration, to make it a 
> bit faster.
> [~Manthan] [~ptuomola] FYI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to