[ https://issues.apache.org/jira/browse/FINERACT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215886#comment-17215886 ]
Michael Vorburger commented on FINERACT-1189: --------------------------------------------- [~aleks] and [~manthan] and [~Grandolf49], I've noticed that in https://github.com/apache/fineract/pull/1402 for this we're not only moving the "Swagger plugin" from {{fineract-provider/build.gradle}} to the (new) {{fineract-client/build.gradle}}, but also replacing {{apply plugin: "org.hidetake.swagger.generator"}} with {{apply plugin: 'org.openapi.generator'}}. Out of curiosity, may I ask what the difference between these is? The {{org.openapi.generator}} "looks more official" (namespace) - what was {{org.hidetake.swagger.generator}}, and why did we (originally) for for that? > fineract-client as separate module > ---------------------------------- > > Key: FINERACT-1189 > URL: https://issues.apache.org/jira/browse/FINERACT-1189 > Project: Apache Fineract > Issue Type: Sub-task > Reporter: Michael Vorburger > Assignee: Aleksandar Vidakovic > Priority: Major > > Would it be possible to extract JUST the work related to making > fineract-client as separate module from > [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171]? > In terms of logical sequencing, perhaps this would be simplest to do after > FINERACT-1188, with fineract-client as the 1st of more to come modules, but > not yet including fineract-api and fineract-doc? > I imagine that this would help with later making FINERACT-1102 possible? > If it's possible, it's perhaps easier if you do not yet include any > improvements to fineract-client - JUST the build changes, and then raise a > separate PR after for changes such as adding > src/main/templates/java/retrofit2/CollectionFormats.mustache and all those > things? Create a separate JIRA, as a subtask here or standalone Improvement, > about whatever all those changes are required for. -- This message was sent by Atlassian Jira (v8.3.4#803005)