[ 
https://issues.apache.org/jira/browse/FINERACT-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216009#comment-17216009
 ] 

Aleksandar Vidakovic commented on FINERACT-1209:
------------------------------------------------

[~vorburger] to answer your first comment: correct, as it is right now adding 
fineract-client to fineract-provider as a dependency would create a loop. 
Personally I'd be all for creating a separate integration test module which is 
really easy now and solves this issue quite elegantly. And like that the 
project would be still independent of any external resources, makes the tests 
more reliable.

As for FINERACT-1216: already assigned myself.

> Integration Tests using new Swagger Client API ("Fineract SDK")
> ---------------------------------------------------------------
>
>                 Key: FINERACT-1209
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1209
>             Project: Apache Fineract
>          Issue Type: New Feature
>            Reporter: Michael Vorburger
>            Priority: Major
>
> Thanks to the progress in FINERACT-1189, I think we're closer than we have 
> ever been to do something I have dreamt of :D for a long time... basically 
> what we were discussing back in the comments of FINERACT-838, copy/paste:
> {quote}(...) include sample code in the repo building against the generated 
> client libraries to test and illustrate their usage. (...) it's still not 
> really "tested" at all, of course. We don't know if the generated code is a 
> working client. (...) In an ideal world, we should have some sort of 
> fineract-client-demo as a small separate project in the git root directory 
> (of Apache Fineract core, not separately/outside!) which depends on 
> fineract-client, and invokes at least some of the generated APIs. This IMHO 
> should always be run, e.g. on Travis CI. We would of course need a "back-end 
> server" - the easiest would probably be to run this against the local server 
> we're anyway starting for integrationTest, in a separate new Gradle task with 
> the appropriate dependencies?{quote}
> Thinking about this again with 2 months distance since writing above, what we 
> probably REALLY should do, I don't know if instead of or in addition to a 
> separate small new {{fineract-client-demo}}, is have (all?) of our ITs (in 
> integrationTest) use the Swagger Client, instead of all those weird hand 
> hard-coded *Utils and *Helper classes with RestAssured - that would be so 
> much nicer!
> [~aleks] [~ChinmayKulkarni] [~ptuomola] [~manthan]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to