[
https://issues.apache.org/jira/browse/FINERACT-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216054#comment-17216054
]
Aleksandar Vidakovic commented on FINERACT-1208:
------------------------------------------------
[~vorburger] Well, when I looked into the Mustache templates of the generator I
saw a couple of ugly parts (one of my favorite: curly braces same/next line).
Enabling full code quality checks would trigger probably some major work
(should be done for all Java generator libraries too); so I'd say this is a bit
out of scope for us. Concerning this one code section that forces us to remove
"-Werror" from fineract-client: no problem, we can submit a PR to OpenAPI;
eventually this will trickle down with an update and we can remove this
exception. That's fairly easy and we would get back at least one line of
defense here.
> -Werror javac compilerArg lost during move to multi modules
> -----------------------------------------------------------
>
> Key: FINERACT-1208
> URL: https://issues.apache.org/jira/browse/FINERACT-1208
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger
> Assignee: Aleksandar Vidakovic
> Priority: Major
> Fix For: 1.5.0
>
>
> While code reviewing https://github.com/apache/fineract/pull/1402/ for
> FINERACT-1189, I've just realized that as part of the overall FINERACT-1171
> effort to move to multi modules, and refactoring moves in the build scripts,
> we could be more careful not to introduce regressions.
> Specifically, I've noticed that the {{-Werror}} javac compilerArg introduced
> in FINERACT-959 was at least temporarily lost again (it's currently commented
> out with a TODO from the root {{/build.gradle}}, and being removed from
> {{fineract-provider/build.gradle}}.
> [~aleks] is this regression something you will fix and raise a PR for?
> [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
