devi-pathak2263 opened a new pull request, #5628: URL: https://github.com/apache/fineract/pull/5628
##Description This PR adds unit tests for the MathUtil utility class located in fineract-core. The MathUtil class contains several helper methods used across the platform for null handling, arithmetic operations, numeric comparisons, and BigDecimal utilities. These utilities are frequently used by different modules and therefore benefit from dedicated test coverage. The added tests verify the behavior of multiple helper methods including: - Null handling utilities (nullToDefault, nullToZero, zeroToNull) - Numeric comparison helpers (isGreaterThanZero, isLessThanZero) - Arithmetic helpers (add, subtract, abs) - BigDecimal helper methods - Percentage calculation (percentageOf) - Formatting utilities such as stripTrailingZeros The tests include validation of typical scenarios as well as important edge cases such as: - null inputs - zero values - negative values - BigDecimal precision handling These tests improve reliability and increase the overall test coverage of shared mathematical utilities used throughout the system. JIRA: https://issues.apache.org/jira/browse/FINERACT-2539 ## Testing Executed locally: ./gradlew spotlessApply ./gradlew :fineract-core:test ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
