debcodes076 opened a new pull request, #5636:
URL: https://github.com/apache/fineract/pull/5636

   ## Description
   This PR addresses Issue 1474 by refactoring the 
`ThitsaWorksCreditBureauIntegrationWritePlatformServiceImplTest.java` file to 
remove hard-coded strings and magic numbers.
   
   ## Changes Made
   - Introduced `private static final` constants for `CREDIT_BUREAU_ID`, 
`TEST_USERNAME`, `TEST_PASSWORD`, and `TEST_URL`.
   - Updated the `setup()` method and all `@Test` cases to utilize these 
constants.
   - Verified that the refactor does not break functionality by running the 
local test suite.
   
   ## Verification
   - Ran the test command: `./gradlew :fineract-provider:test --tests 
"org.apache.fineract.infrastructure.creditbureau.service.ThitsaWorksCreditBureauIntegrationWritePlatformServiceImplTest"`
   - Result: **BUILD SUCCESSFUL**
   
   ---
   ### Checklist
   - [x] Write the commit message as per guidelines
   - [x] Acknowledge that the build passes locally
   - [x] Follow coding conventions
   
   This is my first contribution to Apache Fineract as part of my GSoC 2026 
preparation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to