edk12564 opened a new pull request, #5757:
URL: https://github.com/apache/fineract/pull/5757
JIRA: FINERACT-2568
## Description
Tests were flaky in CI/CD. After diagnosing the build failure, it turns out
that the short name for certain WCL tests were colliding with existing short
names of another product.
After examining the code, we can have rare collisions of product short name
space since UUID.randomUUID().toString().replace("-", "").substring(0, 4)
doesn't deduplicate or check for existing namespace. It turns out there is a
util called Utils.uniqueRandomStringGenerator that can handle this for us. I
refactored the WCL tests to utilize this method.
## Changes
Refactored shortname generation to use Utils.uniqueRandomStringGenerator to
check for existing short names in:
WorkingCapitalLoanProductCRUDTest
WorkingCapitalLoanProductValidationTest
WorkingCapitalLoanApplicationValidationTest
WorkingCapitalLoanApplicationCRUDTest
WorkingCapitalLoanDisbursementTest
WorkingCapitalLoanApprovalRejectionTest
WorkingCapitalLoanDelinquencyRangeScheduleIntegrationTest
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [ ] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
