oleksii-novikov-onix opened a new pull request, #5759:
URL: https://github.com/apache/fineract/pull/5759
## Description
- Fix flaky integration tests that intermittently fail with
duplicate.short.name error
- Three places generated loan product shortName bypassing
uniqueRandomStringContainer, causing collisions within the same JVM/DB
The error has occurred several times recently in GA:
```
CallFailedRuntimeException: HTTP failed:
...url=https://localhost:8443/fineract-provider/api/v1/loanproducts...
errorBody: {"defaultUserMessage":"Loan product with short name `EA12`
already exists",
"userMessageGlobalisationCode":"error.msg.product.loan.duplicate.short.name"}
```
Root cause:
FeignLoanHelper and FeignTrialBalanceSummaryReportTest used
UUID.randomUUID().substring(0,4), and
WorkingCapitalLoanDelinquencyActionIntegrationTest used
Utils.randomStringGenerator() - all bypassing the in-memory
uniqueRandomStringContainer. Later calls to uniqueRandomStringGenerator() could
generate the same value, resulting in a DB unique constraint violation.
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [ ] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
